This repository has been archived by the owner on May 11, 2020. It is now read-only.
Update to run on rust nightly 1.15.0 #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmiyaguchi
force-pushed
the
rust-1.15.0
branch
from
815c0d2
to
dad4ff5
Compare
|
It can be working on the latest stable Rust release? |
|
@stalkerg I took a look at it and I'm not sure if I want to mess around with it. Associated types are behind a feature gate and are being used in the parser for generic programming. I'd rather spend my time doing some other things (namely adding tests). For more reference, here's the tracking issue for associated types if you're curious on how they work and want to tackle it yourself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llamadb is broken in the current rust nightly 1.15.0 release.
The first change is using the
Cow::smart pointer constructor instead ofinto_cow, since it has been depreciated. The other change is to thetime::Durationmodule, where span was depreciated. The idiomatic way to time a function is to useInstant::now()with the correspondingelapsed()function.